-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Notion: migrated to advancedAuth #26535
🐛 Source Notion: migrated to advancedAuth #26535
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
/test connector=connectors/source-notion
Build FailedTest summary info:
|
/test connector=connectors/source-notion
Build FailedTest summary info:
|
@darynaishchenko I tried reproducing this locally with no success. So what ive done (I hope you dont mind) is
Note that if this passes we should be goood! also as of today |
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-notion/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ✅ |
QA checks | ✅ |
Connector package install | ✅ |
Build source-notion docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-notion test
thanks @bnchrch! |
What
#26242
How
authSpecification
withadvancedAuth
in the connector spec